Fix #6702: NPE in getEndColumn for VirtualFile with newlines#6704
Open
caglareker wants to merge 2 commits intoINRIA:masterfrom
Open
Fix #6702: NPE in getEndColumn for VirtualFile with newlines#6704caglareker wants to merge 2 commits intoINRIA:masterfrom
caglareker wants to merge 2 commits intoINRIA:masterfrom
Conversation
getOriginalSourceCode() can return null when using VirtualFile with source containing newlines, causing NPE in getEndColumn().
SirYwell
reviewed
Apr 17, 2026
| CtCompilationUnit cu = launcher.getFactory().CompilationUnit().getMap().values().iterator().next(); | ||
| assertTrue(cu.getPosition().isValidPosition()); | ||
| // should not throw NPE | ||
| cu.getPosition().getEndColumn(); |
Collaborator
There was a problem hiding this comment.
If you want to test for the absence of an exception, use e.g., assertDoesNotThrow. But also please test the expected result; if it makes sense to not throw an exception, then the result should be well-specified.
Author
There was a problem hiding this comment.
good point, switched to assertDoesNotThrow and added an assert on the returned column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6702
getOriginalSourceCode()returns null forVirtualFilethat contains newlines, so the loop insearchColumnNumber()hits NPE. Added a null check around the source access and a small regression test usingVirtualFilewith newlines. Tab counting just gets skipped when source isn't available, columns will be slightly off in that case but no crash.